summaryrefslogtreecommitdiffstats
path: root/drivers/net/tg3.c
diff options
context:
space:
mode:
authorFelix Fietkau2010-02-23 12:45:51 +0100
committerDavid S. Miller2010-02-27 12:16:59 +0100
commitda3f5cf1f8ebb0fab5c5fd09adb189166594ad6c (patch)
treeb00659673aee2b4461b1b7c9b352dc1add211fe4 /drivers/net/tg3.c
parentbonding: fix device leak on error in bond_create() (diff)
downloadkernel-qcow2-linux-da3f5cf1f8ebb0fab5c5fd09adb189166594ad6c.tar.gz
kernel-qcow2-linux-da3f5cf1f8ebb0fab5c5fd09adb189166594ad6c.tar.xz
kernel-qcow2-linux-da3f5cf1f8ebb0fab5c5fd09adb189166594ad6c.zip
skbuff: align sk_buff::cb to 64 bit and close some potential holes
The alignment requirement for 64-bit load/store instructions on ARM is implementation defined. Some CPUs (such as Marvell Feroceon) do not generate an exception, if such an instruction is executed with an address that is not 64 bit aligned. In such a case, the Feroceon corrupts adjacent memory, which showed up in my tests as a crash in the rx path of ath9k that only occured with CONFIG_XFRM set. This crash happened, because the first field of the mac80211 rx status info in the cb is an u64, and changing it corrupted the skb->sp field. This patch also closes some potential pre-existing holes in the sk_buff struct surrounding the cb[] area. Signed-off-by: Felix Fietkau <nbd@openwrt.org> Cc: stable@kernel.org Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tg3.c')
0 files changed, 0 insertions, 0 deletions