diff options
| author | Roel Kluin | 2009-02-03 06:39:02 +0100 |
|---|---|---|
| committer | David S. Miller | 2009-02-03 06:39:02 +0100 |
| commit | 46578a6913e6f5e69229561736b94c18c2e88ae4 (patch) | |
| tree | 23db22f32e094dd971650528ea1d499bd2ab3015 /drivers/net/tsi108_eth.c | |
| parent | qlge: bugfix: Add missing netif_napi_del call. (diff) | |
| download | kernel-qcow2-linux-46578a6913e6f5e69229561736b94c18c2e88ae4.tar.gz kernel-qcow2-linux-46578a6913e6f5e69229561736b94c18c2e88ae4.tar.xz kernel-qcow2-linux-46578a6913e6f5e69229561736b94c18c2e88ae4.zip | |
net: variables reach -1, but 0 tested
while (timeout--) { ... }
timeout becomes -1 if the loop isn't ended otherwise, not 0.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tsi108_eth.c')
| -rw-r--r-- | drivers/net/tsi108_eth.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/tsi108_eth.c b/drivers/net/tsi108_eth.c index 75461dbd4876..a9fd2b2ccaf6 100644 --- a/drivers/net/tsi108_eth.c +++ b/drivers/net/tsi108_eth.c @@ -1237,7 +1237,7 @@ static void tsi108_init_phy(struct net_device *dev) spin_lock_irqsave(&phy_lock, flags); tsi108_write_mii(data, MII_BMCR, BMCR_RESET); - while (i--){ + while (--i) { if(!(tsi108_read_mii(data, MII_BMCR) & BMCR_RESET)) break; udelay(10); |