summaryrefslogtreecommitdiffstats
path: root/drivers/net/usb/lan78xx.c
diff options
context:
space:
mode:
authorJiri Slaby2018-06-25 09:26:27 +0200
committerDavid S. Miller2018-06-26 11:00:44 +0200
commit0ee1f4734967af8321ecebaf9c74221ace34f2d5 (patch)
treee16cf27ce9c677b066ee8f618e5021965107eaca /drivers/net/usb/lan78xx.c
parentMerge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (diff)
downloadkernel-qcow2-linux-0ee1f4734967af8321ecebaf9c74221ace34f2d5.tar.gz
kernel-qcow2-linux-0ee1f4734967af8321ecebaf9c74221ace34f2d5.tar.xz
kernel-qcow2-linux-0ee1f4734967af8321ecebaf9c74221ace34f2d5.zip
r8152: napi hangup fix after disconnect
When unplugging an r8152 adapter while the interface is UP, the NIC becomes unusable. usb->disconnect (aka rtl8152_disconnect) deletes napi. Then, rtl8152_disconnect calls unregister_netdev and that invokes netdev->ndo_stop (aka rtl8152_close). rtl8152_close tries to napi_disable, but the napi is already deleted by disconnect above. So the first while loop in napi_disable never finishes. This results in complete deadlock of the network layer as there is rtnl_mutex held by unregister_netdev. So avoid the call to napi_disable in rtl8152_close when the device is already gone. The other calls to usb_kill_urb, cancel_delayed_work_sync, netif_stop_queue etc. seem to be fine. The urb and netdev is not destroyed yet. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: linux-usb@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/lan78xx.c')
0 files changed, 0 insertions, 0 deletions