diff options
| author | Thomas Meyer | 2011-11-17 13:43:40 +0100 |
|---|---|---|
| committer | David S. Miller | 2011-11-22 21:58:38 +0100 |
| commit | c796984f2f1c528ac21220808525440d49413f8c (patch) | |
| tree | f72a1135540824d4418201963371438c23b080dd /drivers/net/usb | |
| parent | xfrm: optimize ipv4 selector matching (diff) | |
| download | kernel-qcow2-linux-c796984f2f1c528ac21220808525440d49413f8c.tar.gz kernel-qcow2-linux-c796984f2f1c528ac21220808525440d49413f8c.tar.xz kernel-qcow2-linux-c796984f2f1c528ac21220808525440d49413f8c.zip | |
CDC NCM: Use kzalloc rather than kmalloc followed by memset with 0
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous
The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
| -rw-r--r-- | drivers/net/usb/cdc_ncm.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index f06fb78383a1..009dd0f18535 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -465,12 +465,10 @@ static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf) int temp; u8 iface_no; - ctx = kmalloc(sizeof(*ctx), GFP_KERNEL); + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); if (ctx == NULL) return -ENODEV; - memset(ctx, 0, sizeof(*ctx)); - init_timer(&ctx->tx_timer); spin_lock_init(&ctx->mtx); ctx->netdev = dev->net; |