diff options
| author | Bob Copeland | 2009-05-20 05:37:31 +0200 |
|---|---|---|
| committer | John W. Linville | 2009-05-20 20:46:32 +0200 |
| commit | 9c8b3eddc0666255851942df8ec72cd91d22f280 (patch) | |
| tree | beef68ff428b4414073142b34910010411b6aaac /drivers/net/wireless/ath/ath5k/phy.c | |
| parent | cfg80211: fix in nl80211_set_reg() (diff) | |
| download | kernel-qcow2-linux-9c8b3eddc0666255851942df8ec72cd91d22f280.tar.gz kernel-qcow2-linux-9c8b3eddc0666255851942df8ec72cd91d22f280.tar.xz kernel-qcow2-linux-9c8b3eddc0666255851942df8ec72cd91d22f280.zip | |
ath5k: avoid and warn on potential infinite loop
If we are trying to interpolate a curve with slope == 0, the return
value will always be the y-coordinate. In this code we are looping
until we reach a minimum y-coordinate on a line, which in the 0-slope
case can never happen, thus the loop never terminates.
The PCDAC steps come from the EEPROM and should never be equal, but
we should gracefully handle that case, so warn and bail out.
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/ath/ath5k/phy.c')
| -rw-r--r-- | drivers/net/wireless/ath/ath5k/phy.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index d0d1c350025a..a876ca8d69ef 100644 --- a/drivers/net/wireless/ath/ath5k/phy.c +++ b/drivers/net/wireless/ath/ath5k/phy.c @@ -1897,6 +1897,9 @@ ath5k_get_linear_pcdac_min(const u8 *stepL, const u8 *stepR, s16 min_pwrL, min_pwrR; s16 pwr_i; + if (WARN_ON(stepL[0] == stepL[1] || stepR[0] == stepR[1])) + return 0; + if (pwrL[0] == pwrL[1]) min_pwrL = pwrL[0]; else { |