diff options
| author | Mohammed Shafi Shajakhan | 2013-02-22 15:50:21 +0100 |
|---|---|---|
| committer | Kalle Valo | 2013-03-05 08:41:54 +0100 |
| commit | bf9781454731c17085bc4708c09ada50f1b63120 (patch) | |
| tree | f9475b7098322bb874038fb6098973091884b109 /drivers/net/wireless/ath/ath6kl | |
| parent | ath6kl: Protect ath6kl_cfg80211_vif_cleanup using rtnl_locks (diff) | |
| download | kernel-qcow2-linux-bf9781454731c17085bc4708c09ada50f1b63120.tar.gz kernel-qcow2-linux-bf9781454731c17085bc4708c09ada50f1b63120.tar.xz kernel-qcow2-linux-bf9781454731c17085bc4708c09ada50f1b63120.zip | |
ath6kl: Return error from ath6kl_bmi_done()
This addresses a FIXME in the driver.
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Diffstat (limited to 'drivers/net/wireless/ath/ath6kl')
| -rw-r--r-- | drivers/net/wireless/ath/ath6kl/init.c | 6 | ||||
| -rw-r--r-- | drivers/net/wireless/ath/ath6kl/sdio.c | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index 5d434cf88f35..072a2295eff8 100644 --- a/drivers/net/wireless/ath/ath6kl/init.c +++ b/drivers/net/wireless/ath/ath6kl/init.c @@ -1569,11 +1569,9 @@ static int __ath6kl_init_hw_start(struct ath6kl *ar) goto err_power_off; /* Do we need to finish the BMI phase */ - /* FIXME: return error from ath6kl_bmi_done() */ - if (ath6kl_bmi_done(ar)) { - ret = -EIO; + ret = ath6kl_bmi_done(ar); + if (ret) goto err_power_off; - } /* * The reason we have to wait for the target here is that the diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c index d111980d44c0..0bd8ff69461a 100644 --- a/drivers/net/wireless/ath/ath6kl/sdio.c +++ b/drivers/net/wireless/ath/ath6kl/sdio.c @@ -1123,10 +1123,12 @@ static int ath6kl_sdio_bmi_write(struct ath6kl *ar, u8 *buf, u32 len) ret = ath6kl_sdio_read_write_sync(ar, addr, buf, len, HIF_WR_SYNC_BYTE_INC); - if (ret) + if (ret) { ath6kl_err("unable to send the bmi data to the device\n"); + return ret; + } - return ret; + return 0; } static int ath6kl_sdio_bmi_read(struct ath6kl *ar, u8 *buf, u32 len) |