diff options
| author | Johannes Berg | 2017-05-31 14:14:51 +0200 |
|---|---|---|
| committer | Luca Coelho | 2017-06-29 12:26:26 +0200 |
| commit | b092c9f25d45972cf401ad8bcfee2429bf189e2b (patch) | |
| tree | 43f885cf733bde354ac1d008ae33e144cf3e8d45 /drivers/net/wireless/intel/iwlwifi/mvm/ops.c | |
| parent | iwlwifi: pcie: warn if paging is already initialized during init (diff) | |
| download | kernel-qcow2-linux-b092c9f25d45972cf401ad8bcfee2429bf189e2b.tar.gz kernel-qcow2-linux-b092c9f25d45972cf401ad8bcfee2429bf189e2b.tar.xz kernel-qcow2-linux-b092c9f25d45972cf401ad8bcfee2429bf189e2b.zip | |
iwlwifi: mvm: unconditionally stop device after init
In commit b93b1fe3b532 ("iwlwifi: mvm: fix init_dbg flow to work
as expected"), the code was changed to make the stop conditional
on not having failed (and on not having init_dbg), which doesn't
make sense - we should stop the device regardless of failures.
Failure to do so is leading to the device being enabled when it
shouldn't be, and - if it gets re-enabled later - the new context
info code gets confused as paging data wasn't freed.
Remove the invalid error condition again.
Fixes: b93b1fe3b532 ("iwlwifi: mvm: fix init_dbg flow to work as expected")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Diffstat (limited to 'drivers/net/wireless/intel/iwlwifi/mvm/ops.c')
| -rw-r--r-- | drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index a0907762b0bf..c1ce92f5306d 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c @@ -741,7 +741,7 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg, mutex_lock(&mvm->mutex); iwl_mvm_ref(mvm, IWL_MVM_REF_INIT_UCODE); err = iwl_run_init_mvm_ucode(mvm, true); - if (!err || !iwlmvm_mod_params.init_dbg) + if (!iwlmvm_mod_params.init_dbg) iwl_mvm_stop_device(mvm); iwl_mvm_unref(mvm, IWL_MVM_REF_INIT_UCODE); mutex_unlock(&mvm->mutex); |