diff options
| author | Stanislaw Gruszka | 2013-08-01 12:07:55 +0200 |
|---|---|---|
| committer | John W. Linville | 2013-08-02 20:54:04 +0200 |
| commit | 788f7a56fce1bcb2067b62b851a086fca48a0056 (patch) | |
| tree | 95ce469240d45ffbe46df7e8ff13d1719ad26289 /drivers/net/wireless/iwlegacy/4965-mac.c | |
| parent | iwl4965: set power mode early (diff) | |
| download | kernel-qcow2-linux-788f7a56fce1bcb2067b62b851a086fca48a0056.tar.gz kernel-qcow2-linux-788f7a56fce1bcb2067b62b851a086fca48a0056.tar.xz kernel-qcow2-linux-788f7a56fce1bcb2067b62b851a086fca48a0056.zip | |
iwl4965: reset firmware after rfkill off
Using rfkill switch can make firmware unstable, what cause various
Microcode errors and kernel warnings. Reseting firmware just after
rfkill off (radio on) helped with that.
Resolve:
https://bugzilla.redhat.com/show_bug.cgi?id=977053
Reported-and-tested-by: Justin Pearce <whitefox@guardianfox.net>
Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/iwlegacy/4965-mac.c')
| -rw-r--r-- | drivers/net/wireless/iwlegacy/4965-mac.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c index f0b7794fca3e..f2ed62e37340 100644 --- a/drivers/net/wireless/iwlegacy/4965-mac.c +++ b/drivers/net/wireless/iwlegacy/4965-mac.c @@ -4460,12 +4460,12 @@ il4965_irq_tasklet(struct il_priv *il) * is killed. Hence update the killswitch state here. The * rfkill handler will care about restarting if needed. */ - if (!test_bit(S_ALIVE, &il->status)) { - if (hw_rf_kill) - set_bit(S_RFKILL, &il->status); - else - clear_bit(S_RFKILL, &il->status); + if (hw_rf_kill) { + set_bit(S_RFKILL, &il->status); + } else { + clear_bit(S_RFKILL, &il->status); wiphy_rfkill_set_hw_state(il->hw->wiphy, hw_rf_kill); + il_force_reset(il, true); } handled |= CSR_INT_BIT_RF_KILL; |