diff options
| author | David S. Miller | 2008-07-15 09:15:08 +0200 |
|---|---|---|
| committer | David S. Miller | 2008-07-15 09:15:08 +0200 |
| commit | b9e40857682ecfc5bcd0356a23ff409883ffb982 (patch) | |
| tree | d241fd289bed6d16f36f6d26815c1e78e212c89a /drivers/net/wireless/libertas | |
| parent | netdev: Add netdev->addr_list_lock protection. (diff) | |
| download | kernel-qcow2-linux-b9e40857682ecfc5bcd0356a23ff409883ffb982.tar.gz kernel-qcow2-linux-b9e40857682ecfc5bcd0356a23ff409883ffb982.tar.xz kernel-qcow2-linux-b9e40857682ecfc5bcd0356a23ff409883ffb982.zip | |
netdev: Do not use TX lock to protect address lists.
Now that we have a specific lock to protect the network
device unicast and multicast lists, remove extraneous
grabs of the TX lock in cases where the code only needs
address list protection.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wireless/libertas')
| -rw-r--r-- | drivers/net/wireless/libertas/main.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/wireless/libertas/main.c b/drivers/net/wireless/libertas/main.c index 42e9b2771eab..14d5d61cec4c 100644 --- a/drivers/net/wireless/libertas/main.c +++ b/drivers/net/wireless/libertas/main.c @@ -593,8 +593,7 @@ static int lbs_add_mcast_addrs(struct cmd_ds_mac_multicast_adr *cmd, if ((dev->flags & (IFF_UP|IFF_MULTICAST)) != (IFF_UP|IFF_MULTICAST)) return nr_addrs; - netif_tx_lock_bh(dev); - netif_addr_lock(dev); + netif_addr_lock_bh(dev); for (mc_list = dev->mc_list; mc_list; mc_list = mc_list->next) { if (mac_in_list(cmd->maclist, nr_addrs, mc_list->dmi_addr)) { lbs_deb_net("mcast address %s:%s skipped\n", dev->name, @@ -609,8 +608,7 @@ static int lbs_add_mcast_addrs(struct cmd_ds_mac_multicast_adr *cmd, print_mac(mac, mc_list->dmi_addr)); i++; } - netif_addr_unlock(dev); - netif_tx_unlock_bh(dev); + netif_addr_unlock_bh(dev); if (mc_list) return -EOVERFLOW; |