diff options
| author | Yogesh Ashok Powar | 2011-10-05 23:58:24 +0200 |
|---|---|---|
| committer | John W. Linville | 2011-10-11 22:41:11 +0200 |
| commit | 3d82de0fa584fbe73cf74a3bbc906c8710c523b8 (patch) | |
| tree | 7cc59834bd6e7b298b4ceca53ca4c48c9c74c3e0 /drivers/net/wireless/mwifiex/main.c | |
| parent | ath9k: remove some bogus error handling code (diff) | |
| download | kernel-qcow2-linux-3d82de0fa584fbe73cf74a3bbc906c8710c523b8.tar.gz kernel-qcow2-linux-3d82de0fa584fbe73cf74a3bbc906c8710c523b8.tar.xz kernel-qcow2-linux-3d82de0fa584fbe73cf74a3bbc906c8710c523b8.zip | |
mwifiex: fix smatch errors
drivers/net/wireless/mwifiex/main.c +828 mwifiex_remove_card(52)
error: potential null derefence 'priv'.
drivers/net/wireless/mwifiex/main.c +828 mwifiex_remove_card(52)
error: we previously assumed 'priv' could be null (see line 820)
drivers/net/wireless/mwifiex/txrx.c +90 mwifiex_process_tx(24)
error: potential null derefence 'local_tx_pd'.
drivers/net/wireless/mwifiex/sta_ioctl.c +766
mwifiex_rate_ioctl_set_rate_value(30)
error: buffer overflow 'rate' 14 <= 14
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/mwifiex/main.c')
| -rw-r--r-- | drivers/net/wireless/mwifiex/main.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c index 848645118ad4..277ea84a05f5 100644 --- a/drivers/net/wireless/mwifiex/main.c +++ b/drivers/net/wireless/mwifiex/main.c @@ -825,6 +825,10 @@ int mwifiex_remove_card(struct mwifiex_adapter *adapter, struct semaphore *sem) rtnl_unlock(); } + priv = adapter->priv[0]; + if (!priv) + goto exit_remove; + wiphy_unregister(priv->wdev->wiphy); wiphy_free(priv->wdev->wiphy); kfree(priv->wdev); |