diff options
| author | Nathan Chancellor | 2018-09-21 11:48:29 +0200 |
|---|---|---|
| committer | Kalle Valo | 2018-10-01 17:31:10 +0200 |
| commit | f613e4803dd6d1f41a86f6406d4c994fa3d387a0 (patch) | |
| tree | d5c54e93786048e79bdd235e701b235c36ae1112 /drivers/net/wireless/rsi/rsi_91x_mac80211.c | |
| parent | ipw2x00: Remove unnecessary parentheses (diff) | |
| download | kernel-qcow2-linux-f613e4803dd6d1f41a86f6406d4c994fa3d387a0.tar.gz kernel-qcow2-linux-f613e4803dd6d1f41a86f6406d4c994fa3d387a0.tar.xz kernel-qcow2-linux-f613e4803dd6d1f41a86f6406d4c994fa3d387a0.zip | |
rsi: Remove unnecessary boolean condition
Clang warns that the address of a pointer will always evaluated as true
in a boolean context.
drivers/net/wireless/rsi/rsi_91x_mac80211.c:927:50: warning: address of
array 'key->key' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (vif->type == NL80211_IFTYPE_STATION && key->key &&
~~ ~~~~~^~~
1 warning generated.
Link: https://github.com/ClangBuiltLinux/linux/issues/136
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/rsi/rsi_91x_mac80211.c')
| -rw-r--r-- | drivers/net/wireless/rsi/rsi_91x_mac80211.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c index 4e510cbe0a89..e56fc83faf0e 100644 --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c @@ -924,7 +924,7 @@ static int rsi_hal_key_config(struct ieee80211_hw *hw, if (status) return status; - if (vif->type == NL80211_IFTYPE_STATION && key->key && + if (vif->type == NL80211_IFTYPE_STATION && (key->cipher == WLAN_CIPHER_SUITE_WEP104 || key->cipher == WLAN_CIPHER_SUITE_WEP40)) { if (!rsi_send_block_unblock_frame(adapter->priv, false)) |