diff options
| author | Vasanthakumar Thiagarajan | 2015-01-09 18:19:46 +0100 |
|---|---|---|
| committer | Kalle Valo | 2015-01-13 15:22:08 +0100 |
| commit | 5de6dfc82f715b9fe9cf5c0cccce4384a82279ef (patch) | |
| tree | 5c4a073cf6b0f0e949c033f6d79770c5c2b82c7d /drivers/net/wireless | |
| parent | ath10k: fixup wait_for_completion_timeout return handling (diff) | |
| download | kernel-qcow2-linux-5de6dfc82f715b9fe9cf5c0cccce4384a82279ef.tar.gz kernel-qcow2-linux-5de6dfc82f715b9fe9cf5c0cccce4384a82279ef.tar.xz kernel-qcow2-linux-5de6dfc82f715b9fe9cf5c0cccce4384a82279ef.zip | |
ath10k: Fix potential Rx ring corruption
When replenishing Rx buffers driver updates the address of the
buffer and the index of rx buffer in rx ring to the firmware.
Change in order by CPU can cause rx ring corruption. Add memory
barrier before updating rx buffer index to guarantee the order.
This could fix some instances of rx ring corruption due to done
bit in rx attention flag not set.
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Diffstat (limited to 'drivers/net/wireless')
| -rw-r--r-- | drivers/net/wireless/ath/ath10k/htt_rx.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index 9c782a42665e..baa1c447a3b8 100644 --- a/drivers/net/wireless/ath/ath10k/htt_rx.c +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c @@ -97,6 +97,11 @@ static int __ath10k_htt_rx_ring_fill_n(struct ath10k_htt *htt, int num) } fail: + /* + * Make sure the rx buffer is updated before available buffer + * index to avoid any potential rx ring corruption. + */ + mb(); *htt->rx_ring.alloc_idx.vaddr = __cpu_to_le32(idx); return ret; } |