diff options
| author | Brice Goglin | 2006-12-11 11:27:19 +0100 |
|---|---|---|
| committer | Jeff Garzik | 2006-12-11 15:54:06 +0100 |
| commit | 13348beee529cd1200deeac161e1b2de0705b495 (patch) | |
| tree | a68281b8d47b665199481a30431883ed8fed9dd9 /drivers/net | |
| parent | [PATCH] myri10ge: Full vlan frame in small_bytes (diff) | |
| download | kernel-qcow2-linux-13348beee529cd1200deeac161e1b2de0705b495.tar.gz kernel-qcow2-linux-13348beee529cd1200deeac161e1b2de0705b495.tar.xz kernel-qcow2-linux-13348beee529cd1200deeac161e1b2de0705b495.zip | |
[PATCH] myri10ge: fix big_bytes in case of vlan frames
Fix sizing of big_bytes in the case of vlan frames. The 4
VLAN_HLEN bytes were omitted, leading to sizing the big buffer
4 bytes smaller than it should be. Due to how rx buffers are
carved from pages, this was harmless for the common (9000, 1500)
byte MTUs, but could lead to data corruption for some MTUs.
Signed-off-by: Brice Goglin <brice@myri.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/myri10ge/myri10ge.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c index d38217a7eb11..a0d1dae39fd2 100644 --- a/drivers/net/myri10ge/myri10ge.c +++ b/drivers/net/myri10ge/myri10ge.c @@ -1696,11 +1696,11 @@ static int myri10ge_open(struct net_device *dev) * tell him the buffer is larger, because we only use 1 * buffer/pkt, and the mtu will prevent overruns. */ - big_pow2 = dev->mtu + ETH_HLEN + MXGEFW_PAD; + big_pow2 = dev->mtu + ETH_HLEN + VLAN_HLEN + MXGEFW_PAD; if (big_pow2 < MYRI10GE_ALLOC_SIZE / 2) { while ((big_pow2 & (big_pow2 - 1)) != 0) big_pow2++; - mgp->big_bytes = dev->mtu + ETH_HLEN + MXGEFW_PAD; + mgp->big_bytes = dev->mtu + ETH_HLEN + VLAN_HLEN + MXGEFW_PAD; } else { big_pow2 = MYRI10GE_ALLOC_SIZE; mgp->big_bytes = big_pow2; |