diff options
| author | Sucheta Chakraborty | 2013-08-15 14:29:28 +0200 |
|---|---|---|
| committer | David S. Miller | 2013-08-15 23:35:00 +0200 |
| commit | 482b3c3634f73f32bf1059b4470e1c5709c05ddf (patch) | |
| tree | 2da06ad7fc5a4c9c515e76f98c76e3b216721b8c /drivers/net | |
| parent | qlcnic: Fix set driver version command (diff) | |
| download | kernel-qcow2-linux-482b3c3634f73f32bf1059b4470e1c5709c05ddf.tar.gz kernel-qcow2-linux-482b3c3634f73f32bf1059b4470e1c5709c05ddf.tar.xz kernel-qcow2-linux-482b3c3634f73f32bf1059b4470e1c5709c05ddf.zip | |
qlcnic: Fix beacon state return status handling
o Driver was misinterpreting the return status for beacon
state query leading to incorrect interpretation of beacon
state and logging an error message for successful status.
Fixed the driver to properly interpret the return status.
Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c index 10ed82b3baca..660c3f5b2237 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c @@ -170,9 +170,9 @@ static int qlcnic_82xx_store_beacon(struct qlcnic_adapter *adapter, if (ahw->extra_capability[0] & QLCNIC_FW_CAPABILITY_2_BEACON) { err = qlcnic_get_beacon_state(adapter, &h_beacon_state); - if (!err) { - dev_info(&adapter->pdev->dev, - "Failed to get current beacon state\n"); + if (err) { + netdev_err(adapter->netdev, + "Failed to get current beacon state\n"); } else { if (h_beacon_state == QLCNIC_BEACON_DISABLE) ahw->beacon_state = 0; |