summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorTony Breeds2009-04-10 00:29:10 +0200
committerDavid S. Miller2009-04-11 11:48:03 +0200
commit8d1c3c0746098bee8ad116073120166347f21719 (patch)
tree3ef0d293667c0b750c9fe587a897be80c57ed685 /drivers/net
parentixgbe: Update get_physical_layer() calls, plus a version bump (diff)
downloadkernel-qcow2-linux-8d1c3c0746098bee8ad116073120166347f21719.tar.gz
kernel-qcow2-linux-8d1c3c0746098bee8ad116073120166347f21719.tar.xz
kernel-qcow2-linux-8d1c3c0746098bee8ad116073120166347f21719.zip
ixgbe: Be explict with what we are !'ing in ixgbe_sfp_config_module_task()
GCC warns: drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task': drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around operand of '!' or change '&' to '&&' or '!' to '~' Which I think is right. Bracket to remove ambiguity. Signed-off-by: Tony Breeds <tony@bakeyournoodle.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/ixgbe/ixgbe_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 2856486e1655..813c5bc1a8fa 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work)
}
hw->mac.ops.setup_sfp(hw);
- if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
+ if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
/* This will also work for DA Twinax connections */
schedule_work(&adapter->multispeed_fiber_task);
adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;