diff options
| author | Parav Pandit | 2017-01-26 16:17:28 +0100 |
|---|---|---|
| committer | Jens Axboe | 2017-02-22 21:34:00 +0100 |
| commit | 986994a27587efd8ce4c595cab89b570f7475359 (patch) | |
| tree | d15adc87e0864d0a79c1a1cfc01bd16edc076710 /drivers/nvme/target/discovery.c | |
| parent | nvme: add semicolon in nvme_command setting (diff) | |
| download | kernel-qcow2-linux-986994a27587efd8ce4c595cab89b570f7475359.tar.gz kernel-qcow2-linux-986994a27587efd8ce4c595cab89b570f7475359.tar.xz kernel-qcow2-linux-986994a27587efd8ce4c595cab89b570f7475359.zip | |
nvme: Use CNS as 8-bit field and avoid endianness conversion
This patch defines CNS field as 8-bit field and avoids cpu_to/from_le
conversions.
Also initialize nvme_command cns value explicitly to NVME_ID_CNS_NS
for readability (don't rely on the fact that NVME_ID_CNS_NS = 0).
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/nvme/target/discovery.c')
| -rw-r--r-- | drivers/nvme/target/discovery.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/nvme/target/discovery.c b/drivers/nvme/target/discovery.c index 12f39eea569f..af8aabf05335 100644 --- a/drivers/nvme/target/discovery.c +++ b/drivers/nvme/target/discovery.c @@ -186,14 +186,14 @@ int nvmet_parse_discovery_cmd(struct nvmet_req *req) } case nvme_admin_identify: req->data_len = 4096; - switch (le32_to_cpu(cmd->identify.cns)) { + switch (cmd->identify.cns) { case NVME_ID_CNS_CTRL: req->execute = nvmet_execute_identify_disc_ctrl; return 0; default: pr_err("nvmet: unsupported identify cns %d\n", - le32_to_cpu(cmd->identify.cns)); + cmd->identify.cns); return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; } default: |