diff options
| author | Christoph Hellwig | 2017-11-09 14:29:58 +0100 |
|---|---|---|
| committer | Jens Axboe | 2017-11-11 03:53:25 +0100 |
| commit | 5e62d5c993e6889cd314d5b5de6b670152109a0e (patch) | |
| tree | 381ea84b468c5c5b73aaa796d6ee8549599edf55 /drivers/nvme/target/loop.c | |
| parent | nvme-pci: avoid dereference of symbol from unloaded module (diff) | |
| download | kernel-qcow2-linux-5e62d5c993e6889cd314d5b5de6b670152109a0e.tar.gz kernel-qcow2-linux-5e62d5c993e6889cd314d5b5de6b670152109a0e.tar.xz kernel-qcow2-linux-5e62d5c993e6889cd314d5b5de6b670152109a0e.zip | |
nvmet: better data length validation
Currently the NVMe target stores the expexted data length in req->data_len
and uses that for data transfer decisions, but that does not take the
actual transfer length in the SGLs into account. So this adds a new
transfer_len field, into which the transport drivers store the actual
transfer length. We then check the two match before actually executing
the command.
The FC transport driver already had such a field, which is removed in
favour of the common one.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/nvme/target/loop.c')
| -rw-r--r-- | drivers/nvme/target/loop.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c index f40e70eb4a38..96d390416789 100644 --- a/drivers/nvme/target/loop.c +++ b/drivers/nvme/target/loop.c @@ -127,7 +127,7 @@ static void nvme_loop_execute_work(struct work_struct *work) struct nvme_loop_iod *iod = container_of(work, struct nvme_loop_iod, work); - iod->req.execute(&iod->req); + nvmet_req_execute(&iod->req); } static enum blk_eh_timer_return @@ -176,6 +176,7 @@ static blk_status_t nvme_loop_queue_rq(struct blk_mq_hw_ctx *hctx, iod->req.sg = iod->sg_table.sgl; iod->req.sg_cnt = blk_rq_map_sg(req->q, req, iod->sg_table.sgl); + iod->req.transfer_len = blk_rq_bytes(req); } blk_mq_start_request(req); |