diff options
| author | Keith Busch | 2016-12-09 18:08:58 +0100 |
|---|---|---|
| committer | Christoph Hellwig | 2016-12-21 11:33:23 +0100 |
| commit | ff13b39ecf726715a96fcd3c23e50eb792ef6516 (patch) | |
| tree | e5e5a1741ff1fc34caff4de585e96310f3d7fbc6 /drivers/nvme | |
| parent | nvme/pci: Fix whitespace problem (diff) | |
| download | kernel-qcow2-linux-ff13b39ecf726715a96fcd3c23e50eb792ef6516.tar.gz kernel-qcow2-linux-ff13b39ecf726715a96fcd3c23e50eb792ef6516.tar.xz kernel-qcow2-linux-ff13b39ecf726715a96fcd3c23e50eb792ef6516.zip | |
nvme/pci: Delete misleading queue-wrap comment
It is not theoretically possible for this driver to wrap twice while
processing completions. The driver allocates only 'queue_depth - 1'
tags, so there can never be more than that to reap when processing a
completion queue. Removing this misleading comment makes it a little
less likely people with broken controllers will blame the driver for
their spurious interrupts.
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/pci.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 7d6c87028568..151ce59f4ffb 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -712,15 +712,8 @@ static void __nvme_process_cq(struct nvme_queue *nvmeq, unsigned int *tag) req = blk_mq_tag_to_rq(*nvmeq->tags, cqe.command_id); nvme_req(req)->result = cqe.result; blk_mq_complete_request(req, le16_to_cpu(cqe.status) >> 1); - } - /* If the controller ignores the cq head doorbell and continuously - * writes to the queue, it is theoretically possible to wrap around - * the queue twice and mistakenly return IRQ_NONE. Linux only - * requires that 0.1% of your interrupts are handled, so this isn't - * a big problem. - */ if (head == nvmeq->cq_head && phase == nvmeq->cq_phase) return; |