diff options
| author | Florian Fainelli | 2019-05-22 20:35:25 +0200 |
|---|---|---|
| committer | Kishon Vijay Abraham I | 2019-06-12 12:05:44 +0200 |
| commit | d9e100829fca6cbd270d7e005b0c0bb2d14924b8 (patch) | |
| tree | e5545c7027df6f27438734f8dc31fde36bc118a5 /drivers/phy | |
| parent | phy: renesas: rcar-gen2: Fix memory leak at error paths (diff) | |
| download | kernel-qcow2-linux-d9e100829fca6cbd270d7e005b0c0bb2d14924b8.tar.gz kernel-qcow2-linux-d9e100829fca6cbd270d7e005b0c0bb2d14924b8.tar.xz kernel-qcow2-linux-d9e100829fca6cbd270d7e005b0c0bb2d14924b8.zip | |
phy: usb: phy-brcm-usb: Remove sysfs attributes upon driver removal
We are not destroying the sysfs attribute groupe we registered during
the probe function which will make subsequent probe calls to that
driver fail. Correct that with adding a remove function which only
removes those attributes since the reference counting on clocks did its
job already.
Fixes: 415060b21f31 ("phy: usb: phy-brcm-usb: Add ability to force DRD mode to host or device")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/broadcom/phy-brcm-usb.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c index f59b1dc30399..292d5b3fc66c 100644 --- a/drivers/phy/broadcom/phy-brcm-usb.c +++ b/drivers/phy/broadcom/phy-brcm-usb.c @@ -376,6 +376,13 @@ static int brcm_usb_phy_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(phy_provider); } +static int brcm_usb_phy_remove(struct platform_device *pdev) +{ + sysfs_remove_group(&pdev->dev.kobj, &brcm_usb_phy_group); + + return 0; +} + #ifdef CONFIG_PM_SLEEP static int brcm_usb_phy_suspend(struct device *dev) { @@ -441,6 +448,7 @@ MODULE_DEVICE_TABLE(of, brcm_usb_dt_ids); static struct platform_driver brcm_usb_driver = { .probe = brcm_usb_phy_probe, + .remove = brcm_usb_phy_remove, .driver = { .name = "brcmstb-usb-phy", .owner = THIS_MODULE, |