diff options
author | Gustavo A. R. Silva | 2017-07-11 20:34:14 +0200 |
---|---|---|
committer | Linus Walleij | 2017-08-14 15:01:00 +0200 |
commit | 12cb90ba892ed62c469ec7c3e9c9547008946d05 (patch) | |
tree | e99dfa515485a586f7834e073e99c20e36db9558 /drivers/pinctrl/qcom/pinctrl-apq8084.c | |
parent | pinctrl: qcom: ssbi-gpio: constify gpio_chip structure (diff) | |
download | kernel-qcow2-linux-12cb90ba892ed62c469ec7c3e9c9547008946d05.tar.gz kernel-qcow2-linux-12cb90ba892ed62c469ec7c3e9c9547008946d05.tar.xz kernel-qcow2-linux-12cb90ba892ed62c469ec7c3e9c9547008946d05.zip |
pinctrl: qcom: msm: constify gpio_chip structure
This structure is only used to copy into other structure, so declare
it as const.
This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct gpio_chip i@p = { ... };
@ok@
identifier r.i;
expression e;
position p;
@@
e = i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct gpio_chip e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct gpio_chip i = { ... };
In the following log you can see a significant difference in the code size
and data segment, hence in the dec segment. This log is the output
of the size command, before and after the code change:
before:
text data bss dec hex filename
13129 2808 192 16129 3f01 drivers/pinctrl/qcom/pinctrl-msm.o
after:
text data bss dec hex filename
12839 2720 192 15751 3d87 drivers/pinctrl/qcom/pinctrl-msm.o
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/qcom/pinctrl-apq8084.c')
0 files changed, 0 insertions, 0 deletions