diff options
| author | Wei Yongjun | 2013-10-31 08:51:18 +0100 |
|---|---|---|
| committer | Linus Walleij | 2013-11-04 12:49:56 +0100 |
| commit | 5e1109adde6acd0f3424886da09402ac22ed244b (patch) | |
| tree | 834319d549c6b41b94c3794366c028f435b15ba9 /drivers/pinctrl | |
| parent | gpio: tb10x: fix return value check in tb10x_gpio_probe() (diff) | |
| download | kernel-qcow2-linux-5e1109adde6acd0f3424886da09402ac22ed244b.tar.gz kernel-qcow2-linux-5e1109adde6acd0f3424886da09402ac22ed244b.tar.xz kernel-qcow2-linux-5e1109adde6acd0f3424886da09402ac22ed244b.zip | |
pinctrl: imx1: fix return value check in imx1_pinctrl_core_probe()
In case of error, the function devm_ioremap_nocache() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/pinctrl-imx1-core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-imx1-core.c b/drivers/pinctrl/pinctrl-imx1-core.c index 4d5a9e74dc8f..f77914ac081a 100644 --- a/drivers/pinctrl/pinctrl-imx1-core.c +++ b/drivers/pinctrl/pinctrl-imx1-core.c @@ -615,8 +615,8 @@ int imx1_pinctrl_core_probe(struct platform_device *pdev, ipctl->base = devm_ioremap_nocache(&pdev->dev, res->start, resource_size(res)); - if (IS_ERR(ipctl->base)) - return PTR_ERR(ipctl->base); + if (!ipctl->base) + return -ENOMEM; pctl_desc = &imx1_pinctrl_desc; pctl_desc->name = dev_name(&pdev->dev); |