diff options
| author | Axel Lin | 2012-07-17 05:29:03 +0200 |
|---|---|---|
| committer | Mark Brown | 2012-07-17 12:07:26 +0200 |
| commit | 8a165df7a915cb212f41c1dec9abc5ac8f8ee6b6 (patch) | |
| tree | 9fa24c3a01b590e698bf8038b9b30de653494ffd /drivers/regulator/palmas-regulator.c | |
| parent | regulator: lp872x: Simplify implementation of lp872x_find_regulator_init_data() (diff) | |
| download | kernel-qcow2-linux-8a165df7a915cb212f41c1dec9abc5ac8f8ee6b6.tar.gz kernel-qcow2-linux-8a165df7a915cb212f41c1dec9abc5ac8f8ee6b6.tar.xz kernel-qcow2-linux-8a165df7a915cb212f41c1dec9abc5ac8f8ee6b6.zip | |
regulator: palmas: Fix calcuating selector in palmas_map_voltage_smps
The logic of calculating selector in palmas_map_voltage_smps() does not match
the logic to list voltage in palmas_list_voltage_smps().
We use below equation to calculate voltage when selector > 0:
voltage = (0.49V + (selector * 0.01V)) * RANGE
RANGE is either x1 or x2
So we need to take into account with the multiplier set in VSEL register when
calculating selector in palmas_map_voltage_smps()
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Graeme Gregory <gg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/regulator/palmas-regulator.c')
| -rw-r--r-- | drivers/regulator/palmas-regulator.c | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index 7540c95321ce..17d19fbbc490 100644 --- a/drivers/regulator/palmas-regulator.c +++ b/drivers/regulator/palmas-regulator.c @@ -373,11 +373,22 @@ static int palmas_set_voltage_smps_sel(struct regulator_dev *dev, static int palmas_map_voltage_smps(struct regulator_dev *rdev, int min_uV, int max_uV) { + struct palmas_pmic *pmic = rdev_get_drvdata(rdev); + int id = rdev_get_id(rdev); int ret, voltage; - ret = ((min_uV - 500000) / 10000) + 1; - if (ret < 0) - return ret; + if (min_uV == 0) + return 0; + + if (pmic->range[id]) { /* RANGE is x2 */ + if (min_uV < 1000000) + min_uV = 1000000; + ret = DIV_ROUND_UP(min_uV - 1000000, 20000) + 1; + } else { /* RANGE is x1 */ + if (min_uV < 500000) + min_uV = 500000; + ret = DIV_ROUND_UP(min_uV - 500000, 10000) + 1; + } /* Map back into a voltage to verify we're still in bounds */ voltage = palmas_list_voltage_smps(rdev, ret); |