summaryrefslogtreecommitdiffstats
path: root/drivers/rtc/rtc-ds2404.c
diff options
context:
space:
mode:
authorKees Cook2013-11-14 23:31:58 +0100
committerLinus Torvalds2013-11-15 01:32:20 +0100
commit9196436ab2f713b823a2ba2024cb69f40b2f54a5 (patch)
treed10e292c5e307d616edfa13345a6735ed3cc93c9 /drivers/rtc/rtc-ds2404.c
parentseq_file: remove "%n" usage from seq_file users (diff)
downloadkernel-qcow2-linux-9196436ab2f713b823a2ba2024cb69f40b2f54a5.tar.gz
kernel-qcow2-linux-9196436ab2f713b823a2ba2024cb69f40b2f54a5.tar.xz
kernel-qcow2-linux-9196436ab2f713b823a2ba2024cb69f40b2f54a5.zip
vsprintf: ignore %n again
This ignores %n in printf again, as was originally documented. Implementing %n poses a greater security risk than utility, so it should stay ignored. To help anyone attempting to use %n, a warning will be emitted if it is encountered. Based on an earlier patch by Joe Perches. Because %n was designed to write to pointers on the stack, it has been frequently used as an attack vector when bugs are found that leak user-controlled strings into functions that ultimately process format strings. While this class of bug can still be turned into an information leak, removing %n eliminates the common method of elevating such a bug into an arbitrary kernel memory writing primitive, significantly reducing the danger of this class of bug. For seq_file users that need to know the length of a written string for padding, please see seq_setwidth() and seq_pad() instead. Signed-off-by: Kees Cook <keescook@chromium.org> Cc: Joe Perches <joe@perches.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: David Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc/rtc-ds2404.c')
0 files changed, 0 insertions, 0 deletions