diff options
| author | Peter Oberparleiter | 2009-12-18 17:43:23 +0100 |
|---|---|---|
| committer | Martin Schwidefsky | 2009-12-18 17:43:32 +0100 |
| commit | d302e1a5dbe1677a495033a2d310656a55139cdf (patch) | |
| tree | bcf2403ce1f031a576c3166eec62c5e47abab058 /drivers/s390/cio/ccwreq.c | |
| parent | [S390] drivers: Correct size given to memset (diff) | |
| download | kernel-qcow2-linux-d302e1a5dbe1677a495033a2d310656a55139cdf.tar.gz kernel-qcow2-linux-d302e1a5dbe1677a495033a2d310656a55139cdf.tar.xz kernel-qcow2-linux-d302e1a5dbe1677a495033a2d310656a55139cdf.zip | |
[S390] cio: fix channel path vary
Channel path vary is currently broken: channel paths which are varied
offline are still used by Linux. The reason for this is that:
* the path mask indicating which paths of an I/O device can be used
is reset by each internal I/O request
* the logic that checks if a path group is already in its designated
target state incorrectly interprets the result "is correctly set"
as "is correctly set and available"
Fix this by resetting the path mask only for internal I/O requests
which affect the path mask and by correcting the pgid check logic.
Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/cio/ccwreq.c')
| -rw-r--r-- | drivers/s390/cio/ccwreq.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/s390/cio/ccwreq.c b/drivers/s390/cio/ccwreq.c index 9509e3860934..7a28a3029a3f 100644 --- a/drivers/s390/cio/ccwreq.c +++ b/drivers/s390/cio/ccwreq.c @@ -49,7 +49,6 @@ static u16 ccwreq_next_path(struct ccw_device *cdev) */ static void ccwreq_stop(struct ccw_device *cdev, int rc) { - struct subchannel *sch = to_subchannel(cdev->dev.parent); struct ccw_request *req = &cdev->private->req; if (req->done) @@ -57,7 +56,6 @@ static void ccwreq_stop(struct ccw_device *cdev, int rc) req->done = 1; ccw_device_set_timeout(cdev, 0); memset(&cdev->private->irb, 0, sizeof(struct irb)); - sch->lpm = sch->schib.pmcw.pam; if (rc && rc != -ENODEV && req->drc) rc = req->drc; req->callback(cdev, req->data, rc); @@ -80,7 +78,6 @@ static void ccwreq_do(struct ccw_device *cdev) continue; } /* Perform start function. */ - sch->lpm = 0xff; memset(&cdev->private->irb, 0, sizeof(struct irb)); rc = cio_start(sch, cp, (u8) req->mask); if (rc == 0) { |