diff options
| author | Christof Schmitt | 2010-02-17 11:18:53 +0100 |
|---|---|---|
| committer | James Bottomley | 2010-02-18 00:46:24 +0100 |
| commit | 22ed130719987d1081831dc1481160b216224ffd (patch) | |
| tree | df4d50cb0222d80755cb44ed398bc6afbcc06ca8 /drivers/s390/scsi/zfcp_dbf.h | |
| parent | [SCSI] zfcp: Remove unused payload field from zfcp_dbf_san_record (diff) | |
| download | kernel-qcow2-linux-22ed130719987d1081831dc1481160b216224ffd.tar.gz kernel-qcow2-linux-22ed130719987d1081831dc1481160b216224ffd.tar.xz kernel-qcow2-linux-22ed130719987d1081831dc1481160b216224ffd.zip | |
[SCSI] zfcp: Fix warnings from smatch
The smatch tool from http://repo.or.cz/w/smatch.git warns about this:
drivers/s390/scsi/zfcp_scsi.c +64 zfcp_scsi_command_fail(5) warn: variable dereferenced before check 'scpnt->device'
drivers/s390/scsi/zfcp_scsi.c +64 zfcp_scsi_command_fail(5) warn: variable dereferenced before check 'scpnt->device->host'
drivers/s390/scsi/zfcp_scsi.c +93 zfcp_scsi_queuecommand(23) warn: variable dereferenced before check 'unit'
Fix the first two warnings by removing the checks for scpnt->device
and -> host: As long as the SCSI command exists, there is also a
scsi_device and a Scsi_Host.
Fix the last warning by removing the BUG_ON checks in
zfcp_scsi_queuecommand, they are leftovers from previous paranoia
about wrong pointers between data structures.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/s390/scsi/zfcp_dbf.h')
0 files changed, 0 insertions, 0 deletions