diff options
| author | Mahesh Rajashekhara | 2014-01-13 09:20:30 +0100 |
|---|---|---|
| committer | James Bottomley | 2014-03-15 18:19:00 +0100 |
| commit | 6e40e5f021d9f322342f3757d092431ed8c6b6d8 (patch) | |
| tree | cef679f1db26eea1db9b84eff51f0489e5e6e62e /drivers/scsi/aacraid/rx.c | |
| parent | [SCSI] megaraid: missing bounds check in mimd_to_kioc() (diff) | |
| download | kernel-qcow2-linux-6e40e5f021d9f322342f3757d092431ed8c6b6d8.tar.gz kernel-qcow2-linux-6e40e5f021d9f322342f3757d092431ed8c6b6d8.tar.xz kernel-qcow2-linux-6e40e5f021d9f322342f3757d092431ed8c6b6d8.zip | |
[SCSI] aacraid: kdump fix
This patch fixes kernel panic issue while booting into the kdump kernel.
We have triggered crash and kdump vmcore was successful. No issues seen while
booting into the OS.
Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/aacraid/rx.c')
| -rw-r--r-- | drivers/scsi/aacraid/rx.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/scsi/aacraid/rx.c b/drivers/scsi/aacraid/rx.c index dada38aeacc0..bb9917c57760 100644 --- a/drivers/scsi/aacraid/rx.c +++ b/drivers/scsi/aacraid/rx.c @@ -480,7 +480,7 @@ static int aac_rx_ioremap(struct aac_dev * dev, u32 size) static int aac_rx_restart_adapter(struct aac_dev *dev, int bled) { - u32 var; + u32 var = 0; if (!(dev->supplement_adapter_info.SupportedOptions2 & AAC_OPTION_MU_RESET) || (bled >= 0) || (bled == -2)) { @@ -500,13 +500,14 @@ static int aac_rx_restart_adapter(struct aac_dev *dev, int bled) if (bled && (bled != -ETIMEDOUT)) return -EINVAL; } - if (bled || (var == 0x3803000F)) { /* USE_OTHER_METHOD */ + if (bled && (var == 0x3803000F)) { /* USE_OTHER_METHOD */ rx_writel(dev, MUnit.reserved2, 3); msleep(5000); /* Delay 5 seconds */ var = 0x00000001; } - if (var != 0x00000001) + if (bled && (var != 0x00000001)) return -EINVAL; + ssleep(5); if (rx_readl(dev, MUnit.OMRx[0]) & KERNEL_PANIC) return -ENODEV; if (startup_timeout < 300) |