diff options
| author | Michael Reed | 2009-10-09 21:15:59 +0200 |
|---|---|---|
| committer | James Bottomley | 2009-10-29 18:03:28 +0100 |
| commit | 8798a694da59486e4a3ff0abeec183202fb34c20 (patch) | |
| tree | 2410f1f70f7724e41f700c1ec4086f2567208730 /drivers/scsi/bfa/bfa_fcs_lport.c | |
| parent | [SCSI] fix propogation of integrity errors (diff) | |
| download | kernel-qcow2-linux-8798a694da59486e4a3ff0abeec183202fb34c20.tar.gz kernel-qcow2-linux-8798a694da59486e4a3ff0abeec183202fb34c20.tar.xz kernel-qcow2-linux-8798a694da59486e4a3ff0abeec183202fb34c20.zip | |
[SCSI] scsi_transport_fc: remove invalid BUG_ON
I was doing some large lun count testing with 2.6.31 and hit
a BUG_ON() in fc_timeout_deleted_rport(), and it seems like it
should have been just a matter of time before someone did.
It seems invalid to set port_state under lock, then expect it to
remain set after releasing the lock. Another thread called
fc_remote_port_add() when the lock was released, changing the
port_state.
This patch removes the BUG_ON and moves the test of the
port_state to inside the host_lock. It's been running for
several weeks now with no ill effect.
Signed-off-by: Michael Reed <mdr@sgi.com>
Acked-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/bfa/bfa_fcs_lport.c')
0 files changed, 0 insertions, 0 deletions