diff options
| author | James.Smart@Emulex.Com | 2005-10-29 02:30:02 +0200 |
|---|---|---|
| committer | James Bottomley | 2005-10-29 17:31:48 +0200 |
| commit | 0bd4ca25ad2ace4aa717c83dbd4ed21c53c953cb (patch) | |
| tree | 10ae769505f9f306ea7a312663011e95019c34ef /drivers/scsi/lpfc/lpfc_init.c | |
| parent | [SCSI] lpfc: Remove unneeded IOCB_t * cast (diff) | |
| download | kernel-qcow2-linux-0bd4ca25ad2ace4aa717c83dbd4ed21c53c953cb.tar.gz kernel-qcow2-linux-0bd4ca25ad2ace4aa717c83dbd4ed21c53c953cb.tar.xz kernel-qcow2-linux-0bd4ca25ad2ace4aa717c83dbd4ed21c53c953cb.zip | |
[SCSI] lpfc: Fix eh_ return codes for commands
Return FAILED from eh_ routines if command(s) is(are) not completed
There were scenarios where we may have returned from the error
handlers prior to all affected commands being flushed to the midlayer.
Add changes to ensure this doesn't happen.
Signed-off-by: James Smart <James.Smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/lpfc/lpfc_init.c')
| -rw-r--r-- | drivers/scsi/lpfc/lpfc_init.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 59e244f04c32..27390aa0858b 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -870,8 +870,7 @@ lpfc_post_buffer(struct lpfc_hba * phba, struct lpfc_sli_ring * pring, int cnt, int type) { IOCB_t *icmd; - struct list_head *lpfc_iocb_list = &phba->lpfc_iocb_list; - struct lpfc_iocbq *iocb = NULL; + struct lpfc_iocbq *iocb; struct lpfc_dmabuf *mp1, *mp2; cnt += pring->missbufcnt; @@ -880,7 +879,7 @@ lpfc_post_buffer(struct lpfc_hba * phba, struct lpfc_sli_ring * pring, int cnt, while (cnt > 0) { /* Allocate buffer for command iocb */ spin_lock_irq(phba->host->host_lock); - list_remove_head(lpfc_iocb_list, iocb, struct lpfc_iocbq, list); + iocb = lpfc_sli_get_iocbq(phba); spin_unlock_irq(phba->host->host_lock); if (iocb == NULL) { pring->missbufcnt = cnt; |