diff options
| author | James Smart | 2018-01-31 00:58:57 +0100 |
|---|---|---|
| committer | Martin K. Petersen | 2018-02-12 17:43:23 +0100 |
| commit | c1dd9111b7f78a90bccd2e4abb9b9bb6319a4c64 (patch) | |
| tree | 021cdcd43b8b4b7a60c5cb836b14735e8c03f7cc /drivers/scsi/lpfc/lpfc_init.c | |
| parent | scsi: lpfc: Indicate CONF support in NVMe PRLI (diff) | |
| download | kernel-qcow2-linux-c1dd9111b7f78a90bccd2e4abb9b9bb6319a4c64.tar.gz kernel-qcow2-linux-c1dd9111b7f78a90bccd2e4abb9b9bb6319a4c64.tar.xz kernel-qcow2-linux-c1dd9111b7f78a90bccd2e4abb9b9bb6319a4c64.zip | |
scsi: lpfc: Fix SCSI io host reset causing kernel crash
During SCSI error handling escalation to host reset, the SCSI io
routines were moved off the txcmplq, but the individual io's ON_CMPLQ
flag wasn't cleared. Thus, a background thread saw the io and attempted
to access it as if on the txcmplq.
Clear the flag upon removal.
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/lpfc/lpfc_init.c')
| -rw-r--r-- | drivers/scsi/lpfc/lpfc_init.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index bff5c95cf5df..aa7872a7b493 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -958,6 +958,7 @@ lpfc_hba_clean_txcmplq(struct lpfc_hba *phba) struct lpfc_sli_ring *pring; LIST_HEAD(completions); int i; + struct lpfc_iocbq *piocb, *next_iocb; if (phba->sli_rev != LPFC_SLI_REV4) { for (i = 0; i < psli->num_rings; i++) { @@ -983,6 +984,9 @@ lpfc_hba_clean_txcmplq(struct lpfc_hba *phba) if (!pring) continue; spin_lock_irq(&pring->ring_lock); + list_for_each_entry_safe(piocb, next_iocb, + &pring->txcmplq, list) + piocb->iocb_flag &= ~LPFC_IO_ON_TXCMPLQ; list_splice_init(&pring->txcmplq, &completions); pring->txcmplq_cnt = 0; spin_unlock_irq(&pring->ring_lock); |