diff options
| author | Nathan Chancellor | 2018-12-11 00:55:40 +0100 |
|---|---|---|
| committer | Martin K. Petersen | 2019-01-29 07:28:49 +0100 |
| commit | 7e1c99e5c1dd919cd974c4531164c13998e44cba (patch) | |
| tree | c5ec695926a02d323fbfdaf02a7a6c08a9fdd5b1 /drivers/scsi/pcmcia/nsp_cs.c | |
| parent | scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry (diff) | |
| download | kernel-qcow2-linux-7e1c99e5c1dd919cd974c4531164c13998e44cba.tar.gz kernel-qcow2-linux-7e1c99e5c1dd919cd974c4531164c13998e44cba.tar.xz kernel-qcow2-linux-7e1c99e5c1dd919cd974c4531164c13998e44cba.zip | |
scsi: pcmcia: nsp_cs: Remove unnecessary parentheses
Clang warns:
drivers/scsi/pcmcia/nsp_cs.c:1137:27: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
if ((tmpSC->SCp.Message == MSG_COMMAND_COMPLETE)) {
~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/pcmcia/nsp_cs.c:1137:27: note: remove extraneous
parentheses around the comparison to silence this warning
if ((tmpSC->SCp.Message == MSG_COMMAND_COMPLETE)) {
~ ^ ~
drivers/scsi/pcmcia/nsp_cs.c:1137:27: note: use '=' to turn this
equality comparison into an assignment
if ((tmpSC->SCp.Message == MSG_COMMAND_COMPLETE)) {
^~
=
1 warning generated.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/pcmcia/nsp_cs.c')
| -rw-r--r-- | drivers/scsi/pcmcia/nsp_cs.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index 1bd6825a4f14..a81748e6e8fb 100644 --- a/drivers/scsi/pcmcia/nsp_cs.c +++ b/drivers/scsi/pcmcia/nsp_cs.c @@ -1134,7 +1134,8 @@ static irqreturn_t nspintr(int irq, void *dev_id) //*sync_neg = SYNC_NOT_YET; - if ((tmpSC->SCp.Message == MSG_COMMAND_COMPLETE)) { /* all command complete and return status */ + /* all command complete and return status */ + if (tmpSC->SCp.Message == MSG_COMMAND_COMPLETE) { tmpSC->result = (DID_OK << 16) | ((tmpSC->SCp.Message & 0xff) << 8) | ((tmpSC->SCp.Status & 0xff) << 0); |