diff options
| author | Dan Carpenter | 2018-06-28 11:23:10 +0200 |
|---|---|---|
| committer | Martin K. Petersen | 2018-07-02 22:17:22 +0200 |
| commit | 915d9b71422126076f1971f1a44561ae76890060 (patch) | |
| tree | 577e9669b271e08cb17b69a7921e89d7775b0d64 /drivers/scsi/qedi/qedi_main.c | |
| parent | scsi: ibmvscsi: Improve strings handling (diff) | |
| download | kernel-qcow2-linux-915d9b71422126076f1971f1a44561ae76890060.tar.gz kernel-qcow2-linux-915d9b71422126076f1971f1a44561ae76890060.tar.xz kernel-qcow2-linux-915d9b71422126076f1971f1a44561ae76890060.zip | |
scsi: qedi: tidy up a size calculation
The id_tbl->table pointer points to unsigned long so static checkers
complain that instead of 4 we should be allocating sizeof(long) bytes.
We're trying to allocate enough bits for the bitmap. The size variable is
always 1024. (1024 / 32 * 4) is the same as (1024 / 64 * 8) so this
doesn't change runtime, but this is the more idiomatic way to do it and
makes the static checker happy.
[mkp: typo]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/qedi/qedi_main.c')
| -rw-r--r-- | drivers/scsi/qedi/qedi_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index cf274a79e77a..682f3ce31014 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -524,7 +524,7 @@ static int qedi_init_id_tbl(struct qedi_portid_tbl *id_tbl, u16 size, id_tbl->max = size; id_tbl->next = next; spin_lock_init(&id_tbl->lock); - id_tbl->table = kcalloc(DIV_ROUND_UP(size, 32), 4, GFP_KERNEL); + id_tbl->table = kcalloc(BITS_TO_LONGS(size), sizeof(long), GFP_KERNEL); if (!id_tbl->table) return -ENOMEM; |