diff options
| author | Quinn Tran | 2018-08-02 22:16:54 +0200 |
|---|---|---|
| committer | Martin K. Petersen | 2018-08-02 22:56:18 +0200 |
| commit | f6145e86d21fccd59bbb87bc1e1eb076658fd79a (patch) | |
| tree | 41edd1622ea0d380cdeabe672aff4ee00618b26e /drivers/scsi/qla2xxx/qla_gbl.h | |
| parent | scsi: qla2xxx: Fix Management Server NPort handle reservation logic (diff) | |
| download | kernel-qcow2-linux-f6145e86d21fccd59bbb87bc1e1eb076658fd79a.tar.gz kernel-qcow2-linux-f6145e86d21fccd59bbb87bc1e1eb076658fd79a.tar.xz kernel-qcow2-linux-f6145e86d21fccd59bbb87bc1e1eb076658fd79a.zip | |
scsi: qla2xxx: Fix race between switch cmd completion and timeout
Fix race condition between switch cmd completion and timeout timer. Timer
has popped triggers command free. On IOCB completion, stale sp point was
reused. Instead, an abort will be sent to FW to nudge the command out of FW
where the normal completion will take place.
RIP: 0010:qla2x00_chk_ms_status+0xf3/0x1b0 [qla2xxx]
Call Trace:
<IRQ>
qla24xx_els_ct_entry.isra.15+0x1d4/0x2b0 [qla2xxx]
qla24xx_msix_rsp_q+0x39/0xf0 [qla2xxx]
qla24xx_process_response_queue+0xbc/0x2b0 [qla2xxx]
qla24xx_msix_rsp_q+0x8a/0xf0 [qla2xxx]
__handle_irq_event_percpu+0xa0/0x1f0
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/qla2xxx/qla_gbl.h')
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_gbl.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h index 00fbd49a9a7a..6f2a37220a55 100644 --- a/drivers/scsi/qla2xxx/qla_gbl.h +++ b/drivers/scsi/qla2xxx/qla_gbl.h @@ -213,7 +213,7 @@ extern int qla24xx_post_upd_fcport_work(struct scsi_qla_host *, fc_port_t *); void qla2x00_handle_login_done_event(struct scsi_qla_host *, fc_port_t *, uint16_t *); int qla24xx_post_gnl_work(struct scsi_qla_host *, fc_port_t *); -int qla24xx_async_abort_cmd(srb_t *); +int qla24xx_async_abort_cmd(srb_t *, bool); int qla24xx_post_relogin_work(struct scsi_qla_host *vha); /* |