summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/qla2xxx
diff options
context:
space:
mode:
authorChad Dupuis2011-08-16 20:29:24 +0200
committerJames Bottomley2011-08-27 16:18:47 +0200
commit42cd4f5dc2a3de31bfd24642ab4e8b21834a6b78 (patch)
tree4c447aff55eef3f7e37f9d401efae53dbf9cab8f /drivers/scsi/qla2xxx
parent[SCSI] qla2xxx: T10 DIF - Fix incorrect error reporting. (diff)
downloadkernel-qcow2-linux-42cd4f5dc2a3de31bfd24642ab4e8b21834a6b78.tar.gz
kernel-qcow2-linux-42cd4f5dc2a3de31bfd24642ab4e8b21834a6b78.tar.xz
kernel-qcow2-linux-42cd4f5dc2a3de31bfd24642ab4e8b21834a6b78.zip
[SCSI] qla2xxx: Fix qla24xx revision check while enabling interrupts.
Since we enable interrupts before initializing the firmware, use the chip revision from PCI config space directly to perform the chip revision check. Also remove the unnecessary firmware attributes test. Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/qla2xxx')
-rw-r--r--drivers/scsi/qla2xxx/qla_isr.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index ec53e87781a5..477767fcfd1e 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2529,11 +2529,10 @@ qla2x00_request_irqs(struct qla_hw_data *ha, struct rsp_que *rsp)
goto skip_msi;
}
- if (IS_QLA2432(ha) && (ha->pdev->revision < QLA_MSIX_CHIP_REV_24XX ||
- !QLA_MSIX_FW_MODE_1(ha->fw_attributes))) {
+ if (IS_QLA2432(ha) && (ha->pdev->revision < QLA_MSIX_CHIP_REV_24XX)) {
ql_log(ql_log_warn, vha, 0x0035,
"MSI-X; Unsupported ISP2432 (0x%X, 0x%X).\n",
- ha->pdev->revision, ha->fw_attributes);
+ ha->pdev->revision, QLA_MSIX_CHIP_REV_24XX);
goto skip_msix;
}