summaryrefslogtreecommitdiffstats
path: root/drivers/serial
diff options
context:
space:
mode:
authorJoe Eykholt2009-08-25 23:04:08 +0200
committerJames Bottomley2009-09-10 19:08:04 +0200
commite7a51997dad4e17395be1209970e18d2e9305b24 (patch)
tree153db22788bdd7302c6bd58f91a5d5c0da0a4ab6 /drivers/serial
parent[SCSI] libfc: don't swap OX_ID and RX_ID when sending BA_RJT (diff)
downloadkernel-qcow2-linux-e7a51997dad4e17395be1209970e18d2e9305b24.tar.gz
kernel-qcow2-linux-e7a51997dad4e17395be1209970e18d2e9305b24.tar.xz
kernel-qcow2-linux-e7a51997dad4e17395be1209970e18d2e9305b24.zip
[SCSI] fcoe: flush per-cpu thread work when destroying interface
This fixes one cause of an occational problem when unloading libfc where the exchange manager pool doesn't have all items freed. The existing WARN_ON(mp->total_exches <= 0) isn't hit. However, note that total_exches is decremented when the exchange is completed, and it can be held with a refcnt for a while after that. I'm not sure what the offending exchange is, but I suspect it is an incoming request, because outgoing state machines should be all stopped at this point. Note that although receive is stopped before the exchange manager is freed, there could still be active threads handling received frames. This patch flushes the queues by allocating a new skb and sending it through, and have the thread handle this new skb specially. This is similar to the way the work queues are flushed now by putting work items in them and waiting until they make it through the queue. An skb->destructor function is used to inform us of the completion of the flush, and the fr_dev() is left NULL to indicate to fcoe_percpu_receive_thread() that the skb should be just freed. There's already a check for the lp being NULL which prints a message. We skip printing the message if the destructor is for flushing. Signed-off-by: Joe Eykholt <jeykholt@cisco.com> Signed-off-by: Robert Love <robert.w.love@intel.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/serial')
0 files changed, 0 insertions, 0 deletions