diff options
| author | Salah Triki | 2015-10-04 03:49:48 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2015-10-04 10:30:14 +0200 |
| commit | 51abf45c23872df0a43dbe849eb4439ebda6145f (patch) | |
| tree | b89016372e4bbc02e242fbe238181702fc29a2ca /drivers/staging/dgnc/dgnc_sysfs.c | |
| parent | staging: dgnc: remove dgnc_init_globals function (diff) | |
| download | kernel-qcow2-linux-51abf45c23872df0a43dbe849eb4439ebda6145f.tar.gz kernel-qcow2-linux-51abf45c23872df0a43dbe849eb4439ebda6145f.tar.xz kernel-qcow2-linux-51abf45c23872df0a43dbe849eb4439ebda6145f.zip | |
staging: dgnc: take a lock when storing value in dgnc_poll_tick
Reads of dgnc_poll_tick are protected by dgnc_poll_lock spinlock, but the write
to dgnc_poll_tick is not. It could theoretically race.
Signed-off-by: Salah Triki <salah.triki@acm.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/dgnc/dgnc_sysfs.c')
| -rw-r--r-- | drivers/staging/dgnc/dgnc_sysfs.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c index 44db8703eba4..48b605678c32 100644 --- a/drivers/staging/dgnc/dgnc_sysfs.c +++ b/drivers/staging/dgnc/dgnc_sysfs.c @@ -56,11 +56,18 @@ static ssize_t dgnc_driver_pollrate_show(struct device_driver *ddp, char *buf) static ssize_t dgnc_driver_pollrate_store(struct device_driver *ddp, const char *buf, size_t count) { + unsigned long flags; + int tick; int ret; - ret = sscanf(buf, "%d\n", &dgnc_poll_tick); + ret = sscanf(buf, "%d\n", &tick); if (ret != 1) return -EINVAL; + + spin_lock_irqsave(&dgnc_poll_lock, flags); + dgnc_poll_tick = tick; + spin_unlock_irqrestore(&dgnc_poll_lock, flags); + return count; } static DRIVER_ATTR(pollrate, (S_IRUSR | S_IWUSR), dgnc_driver_pollrate_show, |