diff options
| author | Giedrius Statkevičius | 2015-04-10 01:42:30 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2015-05-08 09:24:00 +0200 |
| commit | ce2927e9a3b325b92acfeab66632f9a38d572722 (patch) | |
| tree | 7bb540e7a72113dbdd23f491e8afb1a37eedba33 /drivers/staging/dgnc | |
| parent | staging: dgnc: clean up allocation of ->channels[i] (diff) | |
| download | kernel-qcow2-linux-ce2927e9a3b325b92acfeab66632f9a38d572722.tar.gz kernel-qcow2-linux-ce2927e9a3b325b92acfeab66632f9a38d572722.tar.xz kernel-qcow2-linux-ce2927e9a3b325b92acfeab66632f9a38d572722.zip | |
staging: dgnc: don't forget to check if ->channels[i] is NULL in dgnc_tty_uninit()
Add a check if ->channels[i] is NULL because a NULL pointer may be dereferenced
in case one of the allocations failed
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/dgnc')
| -rw-r--r-- | drivers/staging/dgnc/dgnc_tty.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index a8c88f829e42..6c9261cb88ec 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b/drivers/staging/dgnc/dgnc_tty.c @@ -403,7 +403,9 @@ void dgnc_tty_uninit(struct dgnc_board *brd) dgnc_BoardsByMajor[brd->SerialDriver.major] = NULL; brd->dgnc_Serial_Major = 0; for (i = 0; i < brd->nasync; i++) { - dgnc_remove_tty_sysfs(brd->channels[i]->ch_tun.un_sysfs); + if (brd->channels[i]) + dgnc_remove_tty_sysfs(brd->channels[i]-> + ch_tun.un_sysfs); tty_unregister_device(&brd->SerialDriver, i); } tty_unregister_driver(&brd->SerialDriver); @@ -414,7 +416,9 @@ void dgnc_tty_uninit(struct dgnc_board *brd) dgnc_BoardsByMajor[brd->PrintDriver.major] = NULL; brd->dgnc_TransparentPrint_Major = 0; for (i = 0; i < brd->nasync; i++) { - dgnc_remove_tty_sysfs(brd->channels[i]->ch_pun.un_sysfs); + if (brd->channels[i]) + dgnc_remove_tty_sysfs(brd->channels[i]-> + ch_pun.un_sysfs); tty_unregister_device(&brd->PrintDriver, i); } tty_unregister_driver(&brd->PrintDriver); |