diff options
| author | Sudip Mukherjee | 2015-06-04 15:34:52 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2015-06-08 22:22:45 +0200 |
| commit | e6ffd1ba55a4931c429448cc69db5e7152921c85 (patch) | |
| tree | cfa28dd42809075a2c2e85f7efda698058d3f316 /drivers/staging/fbtft | |
| parent | staging: fbtft: replace fbtft_dev_dbg with standard dev_dbg call (diff) | |
| download | kernel-qcow2-linux-e6ffd1ba55a4931c429448cc69db5e7152921c85.tar.gz kernel-qcow2-linux-e6ffd1ba55a4931c429448cc69db5e7152921c85.tar.xz kernel-qcow2-linux-e6ffd1ba55a4931c429448cc69db5e7152921c85.zip | |
staging: fbtft: fix out of bound access
str was 16 bytes but was mentioned as 128 in snprintf.
again msg is 128 bytes but not sufficient to hold the complete debug
message of register values.
Now removed the use of str, msg and print the register values from the
loop.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/fbtft')
| -rw-r--r-- | drivers/staging/fbtft/fbtft-core.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index d01856f7d1bc..2889f51bf3f8 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -1066,8 +1066,6 @@ static int fbtft_init_display_dt(struct fbtft_par *par) const __be32 *p; u32 val; int buf[64], i, j; - char msg[128]; - char str[16]; fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__); @@ -1093,13 +1091,11 @@ static int fbtft_init_display_dt(struct fbtft_par *par) p = of_prop_next_u32(prop, p, &val); } /* make debug message */ - msg[0] = '\0'; - for (j = 0; j < i; j++) { - snprintf(str, 128, " %02X", buf[j]); - strcat(msg, str); - } fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "init: write_register:%s\n", msg); + for (j = 0; j < i; j++) + fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, + "buf[%d] = %02X\n", j, buf[j]); par->fbtftops.write_register(par, i, buf[0], buf[1], buf[2], buf[3], |