summaryrefslogtreecommitdiffstats
path: root/drivers/staging/greybus/loopback.c
diff options
context:
space:
mode:
authorGreg Kroah-Hartman2015-03-31 23:02:34 +0200
committerGreg Kroah-Hartman2015-03-31 23:02:34 +0200
commit7a51b9362b547b2f02ef88c10636950637c71fa5 (patch)
tree6897be4ad0eddc95d0dbe8c137d28be47287cd31 /drivers/staging/greybus/loopback.c
parentgreybus: loopback: fix build breakage about SZ_4K (diff)
downloadkernel-qcow2-linux-7a51b9362b547b2f02ef88c10636950637c71fa5.tar.gz
kernel-qcow2-linux-7a51b9362b547b2f02ef88c10636950637c71fa5.tar.xz
kernel-qcow2-linux-7a51b9362b547b2f02ef88c10636950637c71fa5.zip
greybus: loopback: use the attribute groups, not group
We should use the attribute groups, not group, for the device, so add and remove it. No one should ever be updating a sysfs group for a device, as that can be pretty dangerous if you don't duplicate _all_ existing attribute for that device, and I don't think we were doing that here. Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Diffstat (limited to 'drivers/staging/greybus/loopback.c')
-rw-r--r--drivers/staging/greybus/loopback.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 7003bce148ff..9914b52c71ce 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -343,7 +343,7 @@ static int gb_loopback_connection_init(struct gb_connection *connection)
gb->connection = connection;
connection->private = gb;
- retval = sysfs_update_group(&connection->dev.kobj, &loopback_group);
+ retval = sysfs_create_groups(&connection->dev.kobj, loopback_groups);
if (retval)
goto error;
@@ -372,7 +372,7 @@ static void gb_loopback_connection_exit(struct gb_connection *connection)
if (!IS_ERR_OR_NULL(gb->task))
kthread_stop(gb->task);
- sysfs_remove_group(&connection->dev.kobj, &loopback_group);
+ sysfs_remove_groups(&connection->dev.kobj, loopback_groups);
kfree(gb);
}