diff options
| author | Johan Hovold | 2015-03-27 12:41:19 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2015-03-30 15:13:01 +0200 |
| commit | e1baa3f0a956764816d0614fb3636ecc7230c171 (patch) | |
| tree | 199bfd31d2a5a5b24e5c9bbcf658759346ad4190 /drivers/staging/greybus/operation.c | |
| parent | greybus: operation: fix incoming request payload size (diff) | |
| download | kernel-qcow2-linux-e1baa3f0a956764816d0614fb3636ecc7230c171.tar.gz kernel-qcow2-linux-e1baa3f0a956764816d0614fb3636ecc7230c171.tar.xz kernel-qcow2-linux-e1baa3f0a956764816d0614fb3636ecc7230c171.zip | |
greybus: operation: replace pr_err with dev_err
Use dev_err whenever we have a connection for more informative error
messages.
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Diffstat (limited to 'drivers/staging/greybus/operation.c')
| -rw-r--r-- | drivers/staging/greybus/operation.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c index 8e37d144c89f..878bfdb6781e 100644 --- a/drivers/staging/greybus/operation.c +++ b/drivers/staging/greybus/operation.c @@ -730,17 +730,19 @@ EXPORT_SYMBOL_GPL(gb_operation_request_send_sync); */ int gb_operation_response_send(struct gb_operation *operation, int errno) { + struct gb_connection *connection = operation->connection; int ret; /* Record the result */ if (!gb_operation_result_set(operation, errno)) { - pr_err("request result already set\n"); + dev_err(&connection->dev, "request result already set\n"); return -EIO; /* Shouldn't happen */ } if (!operation->response) { if (!gb_operation_response_alloc(operation, 0)) { - pr_err("error allocating response\n"); + dev_err(&connection->dev, + "error allocating response\n"); /* XXX Respond with pre-allocated -ENOMEM? */ return -ENOMEM; } @@ -787,8 +789,10 @@ greybus_data_sent(struct greybus_host_device *hd, void *header, int status) */ operation = message->operation; if (message == operation->response) { - if (status) - pr_err("error %d sending response\n", status); + if (status) { + dev_err(&operation->connection->dev, + "error sending response: %d\n", status); + } gb_operation_put(operation); } else if (status) { if (gb_operation_result_set(operation, status)) |