diff options
| author | Bill Pemberton | 2010-05-05 21:27:50 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2010-05-11 20:36:14 +0200 |
| commit | a16e1485c758c236915ac1956694d11bff5e5daa (patch) | |
| tree | 6b9bf7e7767ad56c79d7d11d9b5b8bb5eedcc37e /drivers/staging/hv/RingBuffer.c | |
| parent | staging: hv: check return value of RingBufferInit() (diff) | |
| download | kernel-qcow2-linux-a16e1485c758c236915ac1956694d11bff5e5daa.tar.gz kernel-qcow2-linux-a16e1485c758c236915ac1956694d11bff5e5daa.tar.xz kernel-qcow2-linux-a16e1485c758c236915ac1956694d11bff5e5daa.zip | |
staging: hv: remove ASSERT()s and return -EINVAL in RingBuffer.c
return -EINVAL instead of calling ASSERT() for these conditionals.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/hv/RingBuffer.c')
| -rw-r--r-- | drivers/staging/hv/RingBuffer.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/hv/RingBuffer.c b/drivers/staging/hv/RingBuffer.c index 69f3ebae15a9..64f8d0f9e05c 100644 --- a/drivers/staging/hv/RingBuffer.c +++ b/drivers/staging/hv/RingBuffer.c @@ -490,7 +490,8 @@ int RingBufferRead(RING_BUFFER_INFO *InRingInfo, void *Buffer, u64 prevIndices = 0; unsigned long flags; - ASSERT(BufferLen > 0); + if (BufferLen <= 0) + return -EINVAL; spin_lock_irqsave(&InRingInfo->ring_lock, flags); |