diff options
| author | Heena Sirwani | 2014-10-06 13:34:43 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2014-10-20 04:29:08 +0200 |
| commit | d0e68ce1999e34a29d6b71ced4088d0f916878d4 (patch) | |
| tree | 464a8732213df23fe6140bfe5bf1575cbc846ebf /drivers/staging/iio/Documentation/lsiio.c | |
| parent | Staging: iio: Documentation: Simplify error handling. (diff) | |
| download | kernel-qcow2-linux-d0e68ce1999e34a29d6b71ced4088d0f916878d4.tar.gz kernel-qcow2-linux-d0e68ce1999e34a29d6b71ced4088d0f916878d4.tar.xz kernel-qcow2-linux-d0e68ce1999e34a29d6b71ced4088d0f916878d4.zip | |
Staging: iio: Documentation: Added check for sscanf return value.
The following patch fixes the following checkpatch.pl warning by adding
a check for sscanf return value.
WARNING: unchecked sscanf return value.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/iio/Documentation/lsiio.c')
| -rw-r--r-- | drivers/staging/iio/Documentation/lsiio.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/staging/iio/Documentation/lsiio.c b/drivers/staging/iio/Documentation/lsiio.c index 3b436f13b872..98a0de098130 100644 --- a/drivers/staging/iio/Documentation/lsiio.c +++ b/drivers/staging/iio/Documentation/lsiio.c @@ -63,9 +63,12 @@ static int dump_one_device(const char *dev_dir_name) { char name[IIO_MAX_NAME_LENGTH]; int dev_idx; + int retval; - sscanf(dev_dir_name + strlen(iio_dir) + strlen(type_device), + retval = sscanf(dev_dir_name + strlen(iio_dir) + strlen(type_device), "%i", &dev_idx); + if (retval != 1) + return -EINVAL; read_sysfs_string("name", dev_dir_name, name); printf("Device %03d: %s\n", dev_idx, name); @@ -78,9 +81,12 @@ static int dump_one_trigger(const char *dev_dir_name) { char name[IIO_MAX_NAME_LENGTH]; int dev_idx; + int retval; - sscanf(dev_dir_name + strlen(iio_dir) + strlen(type_trigger), + retval = sscanf(dev_dir_name + strlen(iio_dir) + strlen(type_trigger), "%i", &dev_idx); + if (retval != 1) + return -EINVAL; read_sysfs_string("name", dev_dir_name, name); printf("Trigger %03d: %s\n", dev_idx, name); return 0; |