summaryrefslogtreecommitdiffstats
path: root/drivers/staging/ipack/ipack.c
diff options
context:
space:
mode:
authorSamuel Iglesias Gonsalvez2012-05-25 10:03:02 +0200
committerGreg Kroah-Hartman2012-06-07 07:20:29 +0200
commitb2bc13c5e07501a0a4427b6a9eff8162aef5560a (patch)
treec96aac1acd499d14241781138c9acf1ba5a2e511 /drivers/staging/ipack/ipack.c
parentStaging: ipack: use idr interface for numbering buses (diff)
downloadkernel-qcow2-linux-b2bc13c5e07501a0a4427b6a9eff8162aef5560a.tar.gz
kernel-qcow2-linux-b2bc13c5e07501a0a4427b6a9eff8162aef5560a.tar.xz
kernel-qcow2-linux-b2bc13c5e07501a0a4427b6a9eff8162aef5560a.zip
Staging: ipack: delete the call to remove() in ipack_driver_register
When a bus driver calls ipack_driver_register(), it should manages the returning NULL value to undo all the operations it did before this call, and print the corresponding trace. It is not a task for the ipack driver to call the remove() function here. Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/ipack/ipack.c')
-rw-r--r--drivers/staging/ipack/ipack.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index e97be9960098..a1448e68fd7a 100644
--- a/drivers/staging/ipack/ipack.c
+++ b/drivers/staging/ipack/ipack.c
@@ -141,8 +141,6 @@ struct ipack_device *ipack_device_register(struct ipack_bus_device *bus,
ret = device_register(&dev->dev);
if (ret < 0) {
- pr_err("error registering the device.\n");
- dev->driver->ops->remove(dev);
kfree(dev);
return NULL;
}