diff options
| author | Sebastien Buisson | 2016-03-08 00:10:18 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2016-03-08 01:17:45 +0100 |
| commit | c206f8bc543858ed2d82b1547c1a986dbd3df022 (patch) | |
| tree | 0e7c1f6c307714ac6756e78890720684522ef08c /drivers/staging/lustre | |
| parent | staging: lustre: LNet network latency simulation (diff) | |
| download | kernel-qcow2-linux-c206f8bc543858ed2d82b1547c1a986dbd3df022.tar.gz kernel-qcow2-linux-c206f8bc543858ed2d82b1547c1a986dbd3df022.tar.xz kernel-qcow2-linux-c206f8bc543858ed2d82b1547c1a986dbd3df022.zip | |
staging: lustre: fix 'data race condition' issue in conrpc.c
Fix 'data race condition' defects found by Coverity version 6.5.0:
Data race condition (MISSING_LOCK)
Accessing variable without holding lock. Elsewhere,
this variable is accessed with lock held.
Signed-off-by: Sebastien Buisson <sbuisson@ddn.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2744
Reviewed-on: http://review.whamcloud.com/6567
Reviewed-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/lustre')
| -rw-r--r-- | drivers/staging/lustre/lnet/selftest/conrpc.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c b/drivers/staging/lustre/lnet/selftest/conrpc.c index e6376a01e7a1..8a67f8903a4c 100644 --- a/drivers/staging/lustre/lnet/selftest/conrpc.c +++ b/drivers/staging/lustre/lnet/selftest/conrpc.c @@ -945,8 +945,12 @@ lstcon_sesnew_stat_reply(lstcon_rpc_trans_t *trans, return status; if (!trans->tas_feats_updated) { - trans->tas_feats_updated = 1; - trans->tas_features = reply->msg_ses_feats; + spin_lock(&console_session.ses_rpc_lock); + if (!trans->tas_feats_updated) { /* recheck with lock */ + trans->tas_feats_updated = 1; + trans->tas_features = reply->msg_ses_feats; + } + spin_unlock(&console_session.ses_rpc_lock); } if (reply->msg_ses_feats != trans->tas_features) { |