diff options
| author | Al Viro | 2008-11-01 00:28:30 +0100 |
|---|---|---|
| committer | Linus Torvalds | 2008-11-01 17:49:46 +0100 |
| commit | 233e70f4228e78eb2f80dc6650f65d3ae3dbf17c (patch) | |
| tree | 4e18fbe1851e6d2161b7f18265cb21f8a61e3ce7 /drivers/staging/me4000 | |
| parent | file caps: always start with clear bprm->caps_* (diff) | |
| download | kernel-qcow2-linux-233e70f4228e78eb2f80dc6650f65d3ae3dbf17c.tar.gz kernel-qcow2-linux-233e70f4228e78eb2f80dc6650f65d3ae3dbf17c.tar.xz kernel-qcow2-linux-233e70f4228e78eb2f80dc6650f65d3ae3dbf17c.zip | |
saner FASYNC handling on file close
As it is, all instances of ->release() for files that have ->fasync()
need to remember to evict file from fasync lists; forgetting that
creates a hole and we actually have a bunch that *does* forget.
So let's keep our lives simple - let __fput() check FASYNC in
file->f_flags and call ->fasync() there if it's been set. And lose that
crap in ->release() instances - leaving it there is still valid, but we
don't have to bother anymore.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/staging/me4000')
| -rw-r--r-- | drivers/staging/me4000/me4000.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c index 0b33773bb4f6..cf8b01bcac8d 100644 --- a/drivers/staging/me4000/me4000.c +++ b/drivers/staging/me4000/me4000.c @@ -1633,9 +1633,6 @@ static int me4000_release(struct inode *inode_p, struct file *file_p) free_irq(ext_int_context->irq, ext_int_context); - /* Delete the fasync structure and free memory */ - me4000_ext_int_fasync(0, file_p, 0); - /* Mark as unused */ ext_int_context->in_use = 0; } else { |