diff options
| author | Arnd Bergmann | 2017-03-20 15:41:55 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2017-03-21 08:04:33 +0100 |
| commit | 19740d6840b558bae61d5cbe75c6f430ad1e71b0 (patch) | |
| tree | 50a5781e17c8c4c18e8feca24858c5a40bda6c6a /drivers/staging/media/atomisp/Kconfig | |
| parent | staging/atomisp: add VIDEO_V4L2_SUBDEV_API dependency (diff) | |
| download | kernel-qcow2-linux-19740d6840b558bae61d5cbe75c6f430ad1e71b0.tar.gz kernel-qcow2-linux-19740d6840b558bae61d5cbe75c6f430ad1e71b0.tar.xz kernel-qcow2-linux-19740d6840b558bae61d5cbe75c6f430ad1e71b0.zip | |
staging/atomisp: add PCI dependency
Without CONFIG_PCI, config space reads never return any data,
leading to undefined behavior that gcc warns about:
platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32_raw':
platform/intel-mid/intel_mid_pcihelpers.c:66:9: error: 'data' is used uninitialized in this function [-Werror=uninitialized]
platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32_raw_ext':
platform/intel-mid/intel_mid_pcihelpers.c:84:9: error: 'data' is used uninitialized in this function [-Werror=uninitialized]
platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32':
platform/intel-mid/intel_mid_pcihelpers.c:137:9: error: 'data' is used uninitialized in this function [-Werror=uninitialized]
With a dependency on CONFIG_PCI, we don't get this warning. This seems
safe as PCI config space accessors should always return something
when PCI is enabled.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/media/atomisp/Kconfig')
| -rw-r--r-- | drivers/staging/media/atomisp/Kconfig | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig index 28615aaa2a5d..8b172edf3833 100644 --- a/drivers/staging/media/atomisp/Kconfig +++ b/drivers/staging/media/atomisp/Kconfig @@ -1,6 +1,6 @@ menuconfig INTEL_ATOMISP bool "Enable support to Intel MIPI camera drivers" - depends on X86 && EFI && MEDIA_CONTROLLER + depends on X86 && EFI && MEDIA_CONTROLLER && PCI help Enable support for the Intel ISP2 camera interfaces and MIPI sensor drivers. |