summaryrefslogtreecommitdiffstats
path: root/drivers/staging/media/atomisp/pci/atomisp2
diff options
context:
space:
mode:
authorVarsha Rao2017-03-09 16:50:04 +0100
committerGreg Kroah-Hartman2017-03-09 17:51:11 +0100
commitbf5d0300f1ac9399c3e3d900c5b767081d5f4af9 (patch)
tree630424c32fe9f71de8fc678c6a65469ef7e22c06 /drivers/staging/media/atomisp/pci/atomisp2
parentstaging: lustre: Remove max_u64 function (diff)
downloadkernel-qcow2-linux-bf5d0300f1ac9399c3e3d900c5b767081d5f4af9.tar.gz
kernel-qcow2-linux-bf5d0300f1ac9399c3e3d900c5b767081d5f4af9.tar.xz
kernel-qcow2-linux-bf5d0300f1ac9399c3e3d900c5b767081d5f4af9.zip
staging: media: atomisp: Remove useless cast.
Explicit type casting of variable, with same type as that of variable, is not required. The following coccinelle script is used to remove it. @@ type T; T *ptr; T p; @@ ( - (T *)(&p) + &p | - (T *)ptr + ptr | - (T *)(ptr) + ptr | - (T)(p) + p ) This patch also removes unnecessary parentheses. Signed-off-by: Varsha Rao <rvarsha016@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/media/atomisp/pci/atomisp2')
-rw-r--r--drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_dma_rmgr.c2
-rw-r--r--drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c8
-rw-r--r--drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c2
3 files changed, 6 insertions, 6 deletions
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_dma_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_dma_rmgr.c
index d99150a4aaf4..5032627342d9 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_dma_rmgr.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_dma_rmgr.c
@@ -69,7 +69,7 @@ bool ia_css_isys_dma_channel_rmgr_acquire(
for (i = ISYS2401_DMA_CHANNEL_0; i < N_ISYS2401_DMA_CHANNEL; i++) {
if (bitop_getbit(cur_rsrc->active_table, i) == 0) {
bitop_setbit(cur_rsrc->active_table, i);
- *channel = (isys2401_dma_channel)i;
+ *channel = i;
cur_rsrc->num_active++;
retval = true;
break;
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
index eba96cc2b1c2..b294e6d13762 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
@@ -122,7 +122,7 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia
/* Special case: only one binary in fw */
if (bi == NULL) bi = (const struct ia_css_fw_info *)fw;
- name = (const char *)fw + bi->blob.prog_name_offset;
+ name = fw + bi->blob.prog_name_offset;
blob = (const unsigned char *)fw + bi->blob.offset;
/* sanity check */
@@ -201,7 +201,7 @@ sh_css_check_firmware_version(const char *fw_data)
struct sh_css_fw_bi_file_h *file_header;
firmware_header = (struct firmware_header *)fw_data;
- file_header = (struct sh_css_fw_bi_file_h *)&firmware_header->file_header;
+ file_header = &firmware_header->file_header;
if (strcmp(file_header->version, release_version) != 0) {
return false;
@@ -221,8 +221,8 @@ sh_css_load_firmware(const char *fw_data,
bool valid_firmware = false;
firmware_header = (struct firmware_header *)fw_data;
- file_header = (struct sh_css_fw_bi_file_h *)&firmware_header->file_header;
- binaries = (struct ia_css_fw_info *)&firmware_header->binary_header;
+ file_header = &firmware_header->file_header;
+ binaries = &firmware_header->binary_header;
strncpy(FW_rel_ver_name, file_header->version, min(sizeof(FW_rel_ver_name), sizeof(file_header->version)) - 1);
valid_firmware = sh_css_check_firmware_version(fw_data);
if (!valid_firmware) {
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
index 358d340e7434..a32c9817b800 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
@@ -553,7 +553,7 @@ int hmm_set(ia_css_ptr virt, int c, unsigned int bytes)
vptr = hmm_bo_vmap(bo, true);
if (vptr) {
vptr = vptr + (virt - bo->start);
- memset((void *)vptr, c, bytes);
+ memset(vptr, c, bytes);
clflush_cache_range(vptr, bytes);
hmm_bo_vunmap(bo);
return 0;