diff options
| author | Gustavo A. R. Silva | 2017-08-09 00:50:49 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2017-08-19 00:57:17 +0200 |
| commit | a8e95f8a341097f64c5bc4a82af46050012fe43c (patch) | |
| tree | e6772c5a38cdd671ba5538bb4e9dcb7d52f3787b /drivers/staging/most | |
| parent | staging: wlan-ng: hfa384x.h: Use endian type in 'hfa384x_link_status' struct (diff) | |
| download | kernel-qcow2-linux-a8e95f8a341097f64c5bc4a82af46050012fe43c.tar.gz kernel-qcow2-linux-a8e95f8a341097f64c5bc4a82af46050012fe43c.tar.xz kernel-qcow2-linux-a8e95f8a341097f64c5bc4a82af46050012fe43c.zip | |
staging: most: hdm-dim2: fix error return code in dim2_probe()
platform_get_irq() returns an error code, but the dim2_hdm driver
ignores it and always returns -ENODEV. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.
Also, notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/most')
| -rw-r--r-- | drivers/staging/most/hdm-dim2/dim2_hdm.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c index b1567c80ecd3..df7021c522b3 100644 --- a/drivers/staging/most/hdm-dim2/dim2_hdm.c +++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c @@ -761,8 +761,8 @@ static int dim2_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "failed to get ahb0_int irq\n"); - return -ENODEV; + dev_err(&pdev->dev, "failed to get ahb0_int irq: %d\n", irq); + return irq; } ret = devm_request_irq(&pdev->dev, irq, dim2_ahb_isr, 0, @@ -774,8 +774,8 @@ static int dim2_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 1); if (irq < 0) { - dev_err(&pdev->dev, "failed to get mlb_int irq\n"); - return -ENODEV; + dev_err(&pdev->dev, "failed to get mlb_int irq: %d\n", irq); + return irq; } ret = devm_request_irq(&pdev->dev, irq, dim2_mlb_isr, 0, |