summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rdma/hfi1/chip.c
diff options
context:
space:
mode:
authorBhaktipriya Shridhar2016-02-25 12:52:11 +0100
committerGreg Kroah-Hartman2016-03-12 07:09:09 +0100
commit6d210eef1b31b02ebec37a2ced6e73a1f94aacf1 (patch)
tree861882e7e79f830d8d0d51ce731cf6db18b84155 /drivers/staging/rdma/hfi1/chip.c
parentstaging: rdma: hfi1: Remove unnecessary pci_set_drvdata() (diff)
downloadkernel-qcow2-linux-6d210eef1b31b02ebec37a2ced6e73a1f94aacf1.tar.gz
kernel-qcow2-linux-6d210eef1b31b02ebec37a2ced6e73a1f94aacf1.tar.xz
kernel-qcow2-linux-6d210eef1b31b02ebec37a2ced6e73a1f94aacf1.zip
staging: rdma: hfi1: Remove useless return variables
This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rdma/hfi1/chip.c')
-rw-r--r--drivers/staging/rdma/hfi1/chip.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index 02ba78ff5ca0..46a1830b509b 100644
--- a/drivers/staging/rdma/hfi1/chip.c
+++ b/drivers/staging/rdma/hfi1/chip.c
@@ -1250,11 +1250,8 @@ CNTR_ELEM(#name, \
u64 read_csr(const struct hfi1_devdata *dd, u32 offset)
{
- u64 val;
-
if (dd->flags & HFI1_PRESENT) {
- val = readq((void __iomem *)dd->kregbase + offset);
- return val;
+ return readq((void __iomem *)dd->kregbase + offset);
}
return -1;
}