diff options
| author | Ivan Safonov | 2016-02-11 19:25:30 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2016-02-12 05:03:56 +0100 |
| commit | 8b0187188a423daa741cc544205c224c1ff84c33 (patch) | |
| tree | 5aa3a96111f8b8cf0aa4802d33a5da5f3fec8227 /drivers/staging/rtl8188eu | |
| parent | staging: rtl8188eu: remove pfirmware and fwsize of the hal_data_8188e structure (diff) | |
| download | kernel-qcow2-linux-8b0187188a423daa741cc544205c224c1ff84c33.tar.gz kernel-qcow2-linux-8b0187188a423daa741cc544205c224c1ff84c33.tar.xz kernel-qcow2-linux-8b0187188a423daa741cc544205c224c1ff84c33.zip | |
staging: rtl8188eu: add release_firmware() between request_firmware and function error exit
Small memory leak fixed.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtl8188eu')
| -rw-r--r-- | drivers/staging/rtl8188eu/hal/fw.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 55c17df0e839..656133c47426 100644 --- a/drivers/staging/rtl8188eu/hal/fw.c +++ b/drivers/staging/rtl8188eu/hal/fw.c @@ -175,14 +175,17 @@ int rtl88eu_download_fw(struct adapter *adapt) if (fw->size > FW_8188E_SIZE) { dev_err(device, "Firmware size exceed 0x%X. Check it.\n", FW_8188E_SIZE); + release_firmware(fw); return -1; } trailing_zeros_length = (4 - fw->size % 4) % 4; fw_data = kmalloc(fw->size + trailing_zeros_length, GFP_KERNEL); - if (!fw_data) + if (!fw_data) { + release_firmware(fw); return -ENOMEM; + } memcpy(fw_data, fw->data, fw->size); memset(fw_data + fw->size, 0, trailing_zeros_length); |