diff options
author | Arushi Singhal | 2018-03-03 22:11:42 +0100 |
---|---|---|
committer | Greg Kroah-Hartman | 2018-03-06 13:07:48 +0100 |
commit | 2dcce8ed6633e7da1c1439d4948e19278954e7ef (patch) | |
tree | 005b29e2f6852b000debfd32eabe0ca048072c8e /drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | |
parent | staging: rtl8723bs: Remove unnecessary semicolon. (diff) | |
download | kernel-qcow2-linux-2dcce8ed6633e7da1c1439d4948e19278954e7ef.tar.gz kernel-qcow2-linux-2dcce8ed6633e7da1c1439d4948e19278954e7ef.tar.xz kernel-qcow2-linux-2dcce8ed6633e7da1c1439d4948e19278954e7ef.zip |
staging: rtl8723bs: Replace memset with eth_zero_addr
Use eth_zero_addr to assign zero address to the given address array
instead of memset when the second argument in memset is address
of zero. Coccinelle was used to do the replacement and add the
header file linux/etherdevice.h if not already present.
The Coccinelle semantic patch that makes this change is as follows:
@header@
@@
#include <linux/etherdevice.h>
@r1@
expression e;
@@
-memset(e,0x00,ETH_ALEN);
+eth_zero_addr(e);
@includeheader depends on r1 && !header@
@@
+ #include <linux/etherdevice.h>
#include <...>
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtl8723bs/os_dep/ioctl_linux.c')
-rw-r--r-- | drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index cc18d0ad7d7b..bf437c825733 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -14,6 +14,7 @@ ******************************************************************************/ #define _IOCTL_LINUX_C_ +#include <linux/etherdevice.h> #include <drv_types.h> #include <rtw_debug.h> #include <rtw_mp.h> @@ -124,7 +125,7 @@ void rtw_indicate_wx_disassoc_event(struct adapter *padapter) memset(&wrqu, 0, sizeof(union iwreq_data)); wrqu.ap_addr.sa_family = ARPHRD_ETHER; - memset(wrqu.ap_addr.sa_data, 0, ETH_ALEN); + eth_zero_addr(wrqu.ap_addr.sa_data); } /* @@ -1080,7 +1081,7 @@ static int rtw_wx_set_pmkid(struct net_device *dev, for (j = 0 ; j<NUM_PMKID_CACHE; j++) { if (!memcmp(psecuritypriv->PMKIDList[j].Bssid, strIssueBssid, ETH_ALEN)) { /* BSSID is matched, the same AP => Remove this PMKID information and reset it. */ - memset(psecuritypriv->PMKIDList[ j ].Bssid, 0x00, ETH_ALEN); + eth_zero_addr(psecuritypriv->PMKIDList[j].Bssid); psecuritypriv->PMKIDList[ j ].bUsed = false; break; } @@ -1294,7 +1295,7 @@ static int rtw_wx_get_wap(struct net_device *dev, wrqu->ap_addr.sa_family = ARPHRD_ETHER; - memset(wrqu->ap_addr.sa_data, 0, ETH_ALEN); + eth_zero_addr(wrqu->ap_addr.sa_data); RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("rtw_wx_get_wap\n")); @@ -1303,7 +1304,7 @@ static int rtw_wx_get_wap(struct net_device *dev, ((check_fwstate(pmlmepriv, WIFI_AP_STATE)) == true)) { memcpy(wrqu->ap_addr.sa_data, pcur_bss->MacAddress, ETH_ALEN); } else { - memset(wrqu->ap_addr.sa_data, 0, ETH_ALEN); + eth_zero_addr(wrqu->ap_addr.sa_data); } return 0; |